Design comparison
Solution retrospective
I am just a beginner and would appreciate any feedback.
Do I have good practices? What errors do I have? How could I improve my code?
Thanks <3
Community feedback
- @RocTanweerPosted over 3 years ago
Hello @MasterKrab
Great Work at this one..!
You have really worked on this as it seems.... In a website, there are so many areas to work on and completing all those works is what makes a website awesome, wouldn't you say?
Just like that you have worked really awesome in some area of work but you need to keep working on this project a bit
My suggestions...
- There shouldn't a padding-left on p tag in hero section
- There should be a line-height on p tag all over
- You could use flexBox in hero section to place the hero__text and hero__image
- In feature tab section, A user would appreciate if he/she can change the feature tab just by clicking any where around the feature changer button and not just exactly at it (personal opinion)
- You should style the outline of every buttons and links for keyboard users to navigate through the website(personal opinion)
- Your website needs to be more responsive
I am currently working on this project so there are so many things to say...LOL
Hope it helps...Happy coding and keep coding..! π
3@RocTanweerPosted over 3 years ago@MasterKrab Sorry for late notification... I have completed this project, I would like to have you feedback π
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord