Design comparison
Community feedback
- @joaskrPosted almost 2 years ago
Hi :) Good job with recreating the design
If you want to get rid of accessibility issues you should use the header tags in the correct order in your code - so h1 comes before h2, h2 before h3 and so on. Currently you have <h3> before <h2> and <h2> before <h4> hence the warnings.
As for the HTML validation report - maybe you can consider using a border (top and bottom) and some padding to create these vertical separators instead of <hr>?
I encountered a small bug with your solution - when I open the site on a mobile (for example iPhone SE) device and scroll down to the "Features" section the <p> text under the <h2> is barely visible or even invisible. You might want to look into that.
Overall, good job. Let me know if you have any questions.
Keep coding and good luck with future challenges
Marked as helpful1@Ali503-7Posted almost 2 years ago@joaskr HI, Joanna
and thanks for your report I'm going to work on these bugs
good luck to you too
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord