blogr-landing-page-main Css FlexBox and Grid

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  Greetings bahati7

  So far so good on this project. Here are a few observation from my end.

  • alt values for images should be descriptive for the benefit of assistive technology users. The value should be clear. Words like icon, image, logo etc must be avoided as they are announced automatically by screen readers. If the image is decorative ,use alt=""
  • use semantic elements where possible, interactive elements should be used for click events. <img id="humburger" src="/images/icon-hamburger.svg" alt="icon-hamburger"> . An image should not be used for click events - that will require a lot more coding to make it accessible to assistive technology. In this case a button should have been used , with the image as a child element - the button should have readable text as well.
  • the immediate child of a ul element should be an li element. Buttons and divs cannot be direct children of the the unordered list element.
  • overall, the site is responsive . Check your sect-3 between 915px and 1093px , the paragraph content disappears and after 1093px , check your sect-2 , info class.

  Happy coding

  Marked as helpful

  1

  ---

  

  Philemon Bahati•580

  @bahati7Posted over 2 years ago

  @ChamuMutezva Thanks for your helpful tips. I have just updated my code, you can check out again. Thanks

  0