Blogr-Landing-Page | Reponsive | HTML,CSS,JS

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Tejas! 👋

  Good job on this challenge! Your solution looks quite well and responds good. What I can suggest is:

  • Since your .logo, .editor-img, .laptop, .footer-logo images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.
  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
  • Try to work on the class names, they are non-intuitive and hard to read in the code. Instead of .top-section, .second-section, .third-section use more specific ones like .hero, .about .features etc.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Tejas•265

  @Tejas-117Posted over 3 years ago

  @tediko Thanks a lot for the suggestions. I will sure implement them.

  0
• 

  Nic•595

  @nicm42Posted over 3 years ago

  Looking at this, I'm disappointed your class names aren't weirder - I thought they were quite logical!

  But I'm finding your CSS a bit odd - you have some mobile specific bits, some desktop specific bits and some tablet specific bits. And some navbar links changes only for specific sizes. It's generally easier to design for one size (either small or big) and then work up or down. That way you don't need so many media queries, and you also don't have to have ones that include min and max, as the bottom one takes precedence.

  1

  ---

  

  Tejas•265

  @Tejas-117Posted over 3 years ago

  @nicm42 Thanks for the feedback.

  I usually approach the mobile first workflow, but only for navbar I took the other way around. For me designing mobile navbar was a bit hard that's the reason.😅

  0