Blogr-landing-page

Community feedback

• 

  Ramesh Kumar Munjal•580

  @rameshkmunjalPosted about 2 years ago

  Hello @Tuchpon Congratulations on meeting Blogr-Landing_page challenge.

  I observe following shortcomings in your design . You can improve the page after removing them.

  1. In Desktop design, nav is not as per design. You have given hamburger menu in place of left and right ul.
  2. As per design in challenge , In main part of the page ( complete page minus header and footer), in each section one side is text and other is image . in first and third section you have stacked them one over another.
  3. In mobile design, margin-bottom of section-2 can be reduced. Such large space is not looking well.
  4. Apart from above , you may find some errors in accessability report which can also be removed by slight change in your code. All page content should be contained in one landmark. So your page should be contained like this inside body tag. div.wrapper – nav – main-footer-wrapper-closed. You should use semantic html as max as you can.
     I hope it helps your to improve your skills .

  Thanks for reading .

  1

  ---

  

  newbie•200

  @gidhub48Posted about 2 years ago

  @rameshkmunjal thank you for helping me 😄and for a suggestion, i will improve this.

  0