Blogr site with html css and javascript

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  Greetings Andrei

  This challenge is very tricky and needs some planning and re-planning especially with the navigation and the images display. It wouldn't be a good candidate for a first challenge and would suggest to take a challenge of a lower level than this. Some of the issues that i can identify are:

  • code duplication - the navigation.
  • semantics matters - use elements that are built for the purpose over elements like span and divs.
  • heading h1 is very important and should be always be includes
  • the only direct child of a list (orderedol or ul) is an li element. Any other elements may only come as children of the li
  • site is not responsive

  Good lucky

  Marked as helpful

  0

  ---

  

  Andrei Capi•90

  @lizardcoder9999Posted over 3 years ago

  @ChamuMutezva Thank you it is mobile responsive however but not the best Im going to do a different challenge

  0

  

  Andrei Capi•90

  @lizardcoder9999Posted over 3 years ago

  @ChamuMutezva how could i make it more mobile responsive

  0

  

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  @lizardcoder9999, there is saying which says the web on it self is responsive, we make it unresponsive when we start adding styles. However we have to do it to get that impressive site. Using mobile first is very handy, our content is flowing from top down and that is the greatest advantage of a mobile first approach. You first styles are the base style - you don't need to add a media query yet. It is style for the whole page - when the display starts showing some weakness then think of media queries using min-width. Only change what is breaking or according to the design.

  See this article conquering-responsive-layouts

  0

  

  Andrei Capi•90

  @lizardcoder9999Posted over 3 years ago

  @ChamuMutezva Thank you

  0