Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Thomas, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
header
tag and wrap the navbar for improve the Accessibility - add
main
tag and wrap the content of page for improve the Accessibility - use
ul
for the list of links inside the submenu andnav
- use
button
tag for the buttons istead of styleddiv
- using
<hr>
for the line of mobile menu is not the best way because this tag have a semantic meaning... in this case use div withborder-bottom
because this line is decorative - add
transition
on the element with hover effect
Overall you did well 😁 Hope this help!
Marked as helpful0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord