Blogr Landing Page with React, Scss/Sass and Typescript

Community feedback

• 

  Zineb Boutaa•750

  @zineb-BouPosted over 2 years ago

  Hi there, your solution looks good, is nicely responsive and I love the animation on the header, here are some suggestions concerning accessibility.

  1. The pattern images are only for decoration, we don’t need the screen readers to read their source path, therefore we have to hide them from assistive technologies using aria-hidden=” true”
  2. The close button on the navigation menu is a button, so use the right HTML semantic element which is a <button> instead of a <div>.

  Good luck

  Marked as helpful

  1

  ---

  

  Dante_benicio•260

  @DanteBenicioPosted over 2 years ago

  @zineb-Bou Thanks for the tip, I'm starting to study these accessibility issues and that's why there are still things I don't know yet, but thanks, I'll do that 👍

  0
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey good job completing this challenge.

  Keep up the good work

  Your solution looks great however I think the description next to the phone mockup is supposed to have some margin on the left using margin-left.

  I hope this helps

  Cheers Happy coding 👍

  Marked as helpful

  1

  ---

  

  Dante_benicio•260

  @DanteBenicioPosted over 2 years ago

  @TheCoderGuru Thanks for the tip bro, I'll do that 👍

  0