Design comparison
SolutionDesign
Community feedback
- @denieldenPosted almost 2 years ago
Hello Rob, You have done a good work! 😁
Some little tips to improve your code:
- add
header
tag and wrap the navbar for improve the Accessibility - add
main
tag and wrap the main content of page for improve the Accessibility - add
footer
tag and wrap the last section of the page for improve the Accessibility - Using
<hr>
for the line is not the best way because this tag have a semantic meaning... in this case use div withborder-bottom
because this line is decorative - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of images - add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord