Blogr Landing Page with HTML,CSS,JS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey, Jorge A. Mendoza II! 👋

  Good job on this challenge! 👏 Your solution looks pretty good and is responsive! 🙌

  One more tiny thing that I suggest (in addition to emestabillo's helpful feedback) is to consider closing any open submenus in the header navigation when another submenu is opened (if you're up for the challenge). 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Jorge A. Mendoza II•720

  @JorgeAMendozaPosted over 3 years ago

  @ApplePieGiraffe Thank you for the response! I'll try to implement your feedback thos weekend!

  0
• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted over 3 years ago

  Hi @JorgeAMendoza, good job on this project. Site is responsive and looks similar to the design. You could, however, get closer still by tweaking the font-sizes and spacing. Two other things that I noticed:

  • I think you were going for BEM here, but nav-bar__nav__list__option__items__item goes against convention and is more like block__element__element__element__element__element. I suggest further reading to get a better grasp such as this article

  • The links and buttons could use transitions

  Hope this helps!

  1

  ---

  

  Jorge A. Mendoza II•720

  @JorgeAMendozaPosted over 3 years ago

  @emestabillo Thank you so much for the feedback!

  1