Blogr landing page with Flexbox, BEM & Sass

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Michael Kret! 👋

  Congrats on finishing another challenge! Your solution responds well and looks good. What I'd suggest you is:

  • Change the alt attributes for the .header__logo and .footer__logo, as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.
  • I can't access your dropdowns using my keyboard because you trigger them on :hover.
  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Michael Kret•470

  @atekronPosted over 3 years ago

  @tediko thanks, it's a great feedback, I'll fix all of that shortly

  0