Blogr Landing Page using Html Css JavaScript

Community feedback

• 

  dgjenni2•320

  @dgjenni2Posted about 2 years ago

  1. I like how your class names are specific to sections, but you could make some css classes shared between elements, such as using a container class in each section to set the margin and padding of the text areas.
  2. Make sure you fix typos like the repeated discription in class names which should be description. While a typo may seem like a small problem, if you work with other developers and they try to reuse your classname with the correctly spelled word, their css would not work because of the typo.
  3. Seems like there's an unnecessary amount of divs within the code. It would probable be useful to use other HTML5 tags instead of using div for every container. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element#content_sectioning
  4. Don't know what the .color class is supposed to do. Is it really just overwriting the color property repeatedly?
  5. There's some console.log() statements that print "gg" to the console. Make sure log statements like that don't get into final builds, since in a corporate environement, those might expose sensitive information that you don't want outside users knowing about.

  Marked as helpful

  0

  ---

  

  htet-myet•480

  @htet-myetPosted about 2 years ago

  @dgjenni2 Thanks a lots , I was confused about the naming classes . The .color class is to recommend the color when I type it so I can easy to use it but I forgot to remove it . And the Js testing "gg" too. Thanks for your advice bro I'm really appreciated. :)

  1