blogr Landing page - using Flexbox

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted almost 3 years ago

  • the direct child of an ul or ol is an li element. A div can not be the immediate child of these 2 list.
  • alt values should provide information that is beneficial to assistive technology users. Decorative images must have an empty alt value.
  • with responsive design , there should only be one navigation menu - having a mobile navigation and another for desktop is not best practice. Html structure is very important and the best to view it is when you disable your css.

  <li class="toggle" > <a href="#"><img src="images/icon-hamburger.svg" alt="hamburger toggle"></a></li>
          <li class="toggle cross"><a href="#"><img src="images/icon-close.svg" alt="hamburger close" ></a></li>
  

  • the hamburger and close should be buttons - these are meant to toggle the navigation container. The navigation elements are the once that should be anchor elements.
  • the elements below are supposed to be navigation elements not buttons. Use buttons for tasks such as opening and closing modals and navigation is for navigating to other pages or sections.

  <div class="cta-buttons">
                  <button class="btn primary" href="#">Start for Free</button>
                  <button class="btn secondary" href="#">Learn More</button>
              </div>
  

  • <div class="mobile-laptop" alt="mobile laptop"></div> , an alt value is reserved for an image not divs
  • at least keep your js at the bottom of your html , having a mix of html and js is not something that is encouraged. The best is to have a separate js file
  • well done site is responding well on most devices

  Marked as helpful

  1

  ---

  

  LyleRems•60

  @LyleRemsPosted almost 3 years ago

  @ChamuMutezva Thank you for taking the time to look at my code, Chamu. I appreciate your feedback. I will take note of those things you pointed out to help me for next time. There is a lot of room for improvement on this one. Cheers!

  1