Travolgi 🍕• 31,420
@denielden
Posted
Hi Aldi, congratulations on completing the challenge, great job! 😁
Some little tips for optimizing your code:
- add
header
tag and wrap the navbar for improve the Accessibility - add
main
tag and wrap the all main content of page for improve the Accessibility - add
footer
tag and wrap the footer dark of page for improve the Accessibility - add descriptive text in the
alt
attribute of the images - the image of section are broken because url in the css sheet is wrong
background-image: url(images/illustration-laptop-desktop.svg)
- alternatively you can use the
picture
tag which allows you to change image based on resolution forsection
images -> read here - the mobile navbar pannel isen't centered
- add
transition
on the element with hover effect - instead of using
px or %
use relative units of measurement likerem
-> read here
Hope this help! Happy coding 😉
0