Blogr Landing Page (HTML, CSS, Js)

Community feedback

• 

  David•8,000

  @DavidMorgadePosted over 2 years ago

  Hello Lesley, congrats on finishing the challenge!, don't bash yourself, it looks pretty good and the nav is working perfectly!

  If you don't mind, I will like to give you some feedback.

  1. The problem that you had is that you made your header, too much content, try getting only the logo, the navbar and the singin buttons as your header, and then divide the rest of the content con main and sections. The part of your website that is just after the navbar is what usually people call hero, this should not be a part of your header IMO.

  2. You also have saved a lot of time on paddings and margins on the header just calling flex on your header and aligning the content should do the job:

  .primary-header {
  justify-content: space-around;
  display: flex;
  flex-direction: column;
  align-items: center;
  }
  

  But your solution got the same result so, don't worry about that!

  Apart from that your project looks great IMO.

  Hope my feedback helps you in future challenges, good job!

  Marked as helpful

  0

  ---

  

  Lesley Kimutai•565

  @LeskimPosted over 2 years ago

  @DavidMorgade Thanks David🤝🏾 ...I'll divide the header as such in the future

  1