Blogr landing page from beginner.

Community feedback

• 

  Katie•405

  @kem522Posted about 3 years ago

  Hi there, good work!

  I have a couple of pieces of advice for you.

  The first is that for out HTML to be accessible and not repetitive it is better not to have separate markup for the desktop header and the mobile header. Instead it's best to have the content only once and then use CSS and media queries to style it differently at different breakpoints. Here is an example of how to do that: https://jsfiddle.net/kmturley/o45weyvj/

  The other is that you have overloaded some of your elements with classes for example <div class="designed-text-div freeopen-text-div">. In this case all of the rules of the first class are overwritten by the rules in the second class since they both have just width and padding so you should remove the first class from this element.

  Also, for this element <p class="designed-text freeopen-text"> there is no class called freeopen-text so that should be deleted. If you intend to use designed-text here as well then the classname should be more generic as the designed part suggests it belongs to the content higher up the page.

  Hope that was helpful! Happy coding!

  Marked as helpful

  1

  ---

  

  bbnos202•195

  @bbnos202Posted about 3 years ago

  @kem522 Thank you for your help. I will try to fix it. :)

  0