Blogr landing page

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi Misa Dervisevic, congratulations on your first solution!

  ’ve few suggestions for you that you can consider adding to your code:

  When you add some hover effects you've to think that for the mobile version there's an issue that the elements with hover get stuck on the active state of the hover until you click on something else. Something you can do to avoid this problem on mobile, the stick hover, is to add a media query saying that you want hover effects only on devices that are not touch. So you can use:

  @media (hover: hover) {
  {ADD HERE ALL THE CLASSES WITH HOVER EFFECTS TO DISABLE IT ON MOBILE}
  }
  

  You made your html structure entirely with div blocks but these div doesn't any semantic meaning, for this reason is better you use a better html markup improving your code, for example for each section you use <section> instead of the <div>.

  This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Misa, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • use nav tag only to contain the navigation link
  • use header tag to wrap the navbar of the site and improve the Accessibility
  • add main tag to wrap all content of page and improve the Accessibility
  • you can use picture tag to change image by resolution -> read here
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of images
  • instead of using px use relative units of measurement like rem -> read here
  • fix the position of mobile nav pannel

  Hope this help! Happy coding 😉

  Marked as helpful

  1

  ---

  

  Misa Dervisevic•150

  @DervisevicMPosted about 2 years ago

  @denielden Hi Daniel, Thanks, your suggestions will help me a lot!

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @DervisevicM You are welcome and keep it up :)

  Marked as helpful

  1