blogr landing page using flexbox and jquery

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 2 years ago

  Hi there, Chris! 👋

  Nice job on this challenge! 👏 Your solution looks good and is responsive! 😁

  I'd like to suggest,

  • Turning the navigation links in the footer of the page into actual links by wrapping each of them in an a tag. It would also be a good idea to use the ul and li elements for each of those groups of links since they are lists of items.
  • Using button elements for the elements that show/hide the dropdown menus in the header of the page (as well as for the hamburger menu button).
  • Setting the alt attributes for the icons in the hamburger menu to an empty string so that they will be ignored by screen readers and adding an aria-label to the button to identify it.
  • It may be worth setting the values for properties like margin and padding in em and rem too (instead of px) so that those values will scale with the root/parent font size. That way, the entire design of your site will change with the font-size.

  Hope you find these tips helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  0

  ---

  

  Chris•1,030

  @BlackSun225Posted almost 2 years ago

  @ApplePieGiraffe thanks for your advices

  1