Design comparison
Solution retrospective
Will try to improve CSS
What challenges did you encounter, and how did you overcome them?None
What specific areas of your project would you like help with?Responsiveness
Community feedback
- @danielmrz-devPosted 7 months ago
Hello there!
Congrats on completing the challenge! ā
Your solution looks excellent!
I have just one suggestion:
- Use
<main>
to wrap the main content instead of<article>
.
š The tag
<article>
would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0 - Use
- @siddarthm93Posted 7 months ago
Hi Ishank Gupta,
congratulations for completing the task, you have done a good work. i liked the way u used the css but one feedback was you have used the landmarks more which is unnecessary try to avoid it, as it is a card try to use accordingly like "div class="card" ,card-header, card-body and card-footer".
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord