Blog-preview-card-main

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 7 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change the <section> to a <main>.

  • Consider using the <time> element for the date:<p>Published <time datetime="2023-12-21">21 Dec 2023</time></p>.

  • As this is a blog card, the heading needs a link inside.

  • The profile image needs alt text, something like "Headshot of Gary Hooper" works fine.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • It's not common to place list-style and text-decoration on the universal selector (*), as these properties only apply to certain elements.

  • Remember to specify a fallback font, in case the user can't access the declared font:font-family: 'Figtree', sans-serif;.

  • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Except for the profile image, remove all widths.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • Images need display: block and max-width: 100% - the max-width prevents it from overflowing its container.

  • Media queries should be in rem. Remember, you only have to declare properties that you want to override. Hence, you don't need to write display: flex and flex-direction: column in the media queries for .container and blackContainer.

  1
• 

  Rupak Mukherjee•970

  @hannibal1631Posted 7 months ago

  NA

  0