Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

blog-preview-card-main

@hgcfkuyfliyfl

Desktop design screenshot for the Blog preview card coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


all kinds of feedback is welcome

Community feedback

P

@Islandstone89

Posted

HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Wrap .container in a <main>.

  • "Learning" is not a <button> - buttons are used for triggering an action. Change it to a <p>.

  • Wrap the date in a <time> element:<time datetime="2023-12-21">21 Dec 2023</time>.

  • Headings should always be in order, so you never start with a <h3>. Change it into a <h1>.

  • The profile image needs a short and descriptive alt text.

  • Change "Gary Hooper" to a <p>.

CSS:

  • It's good practice to include a CSS Reset at the top.

  • Use the style guide to find the correct font-family.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • Remove the margin on the card.

  • To center the card horizontally and vertically, use Flexbox on the body:

display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
min-height: 100svh;
  • Remove the width on the card.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Remove opacity: 50%, as it makes the text harder to read.

  • Remove float: left. Instead, add display: flex and align-items: center on .comb.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord