Design comparison
Solution retrospective
Proud of the layout, adjust the scroll
What challenges did you encounter, and how did you overcome them?overcoming font-family
What specific areas of your project would you like help with?the responsiveness of it to other devices
Community feedback
- @0xabdulkhaliqPosted 6 months ago
Hello there š. Congratulations on successfully completing the challenge! š
- I have a suggestion regarding your code that I believe will be of great interest to you.
CSS šØ:
- You have used
margin
andpadding
to center the component but it's not work as you intended.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here š.
- For this demonstration we use css
Grid
to center the component.
body { min-height: 100vh; display: grid; place-items: center; }
- Now remove these styles, after removing you can able to see the changes
body { padding: 5rem 1rem; } .container { margin-inline: auto; }
- Now your component has been properly centered
.
I hope you find this helpful š Above all, the solution you submitted is great !
Happy coding!
0 - @danielmrz-devPosted 6 months ago
Hello there!
Congrats on completing the challenge! ā
Your solution is really impressive!
I've got a couple of ideas (about how to use HTML better) that could make it even stronger:
š First: Think about using
<main>
to wrap your main content instead of<div>
.Imagine
<div>
and<span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.š Second: Don't skip heading levels ā start with
<h1>
, then use<h2>
, and so on.It's more than just text size ā it's about structuring your content effectively:
- The
<h1>
to<h6>
tags are used to define HTML headings. <h1>
is for the most important heading.<h6>
is for the least important heading.- Stick to just one
<h1>
per page ā it should be the main title for the whole page.
These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.
Hope that's helpful!
Keep up the great work!
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord