Design comparison
SolutionDesign
Community feedback
- @AGutierrezRPosted 11 months ago
Hello there @DebabrataBanik 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
General Structure and HTML:
- Consider using
<span>
or<time>
instead of paragraphs for elements that are not actual paragraphs like "Learning" and "Published...".
CSS and Styling:
- You could add the hover effect to the title. Change the color to yellow and implement a
cursor: pointer
.
Accessibility and Semantic HTML:
- The icons/illustration images are decorative, so their alt text must be empty:
alt=""
. - Profile image could benefit from a more descriptive alt text, like
alt="Headshot of Greg Hooper"
.
I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!
Happy coding!
Marked as helpful1 - Consider using
- @AhlamAb22Posted 11 months ago
Great work! I assume this should be <a> instead of <h2> because it's clickable.
Also, consider using rem or em instead of px for font-size.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord