@zacc-anyona
Posted
Hello Monfaredz,
Congratulations on taking your time and effort to complete this challenge. You have done well. But there are some areas you can improve on;
-
Learn to use HTML landmarks. Starting now start using HTML5 landmarks such as
<main></main>,<article></article>&<footer></footer>. Landmarks contribute greatly on your website's accessibility. Landmarks also help search engines and screen readers know the flow of content on your web-page. For example your<div class="container"></div>you could have replaced it with<main class="container"></main>. Main tag indicates that is the main content of your web page. Learn to use landmarks here. Refuse to suffer from a disease called 'Divitis', most web developers suffer from it. It is a pandemic! I myself used to suffer from it. :) -
Use the modern css reset. Using the modern css reset will save you a lot of time when designing your page. Get up to speed with modern CSS reset here.
-
There is an efficient and simple way to center your content both vertically and horizontally. Allow me to demonstrate;
body {
height: 100dvh;
display: flex;
flex-direction: column;
justify-content: center; /*centers horizontally*/
align-items: center; /*centers vertically*/
}
Generally you have done great. I love it. If you find my comment helpful don't forget to mark it as helpful and give me an upvote.
Marked as helpful
