Design comparison
Solution retrospective
Evaluate my work
Community feedback
- @rayaattaPosted 10 months ago
Hello πm07mmad-nasr, Congratulations on completing this challenge π
I have some suggestions for you
1 Use
<main>
to wrap the main content instead of<article>
. The<article>
element would make more sense if the card was part of a bigger website (it certainly would be in real life), but here it is all we have on the screen.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
2 The alt tag for the avatar image should contain the name of the person on the image i.e
alt="Greg Hooper"
You can check out this article.3 In your html I noticed
<h2>Published 21 Dec 2023</h2>
When a screen reader is reading the above it will pronounce
21 Dec 2023
as it is. This should be wrapped in<time datetime="2023-12-21">21 Dec 2023</time>
This is machine readable therefore it is more accessible. To find out more about the time tag check out this articleπ.
I hope it helps!
Other than that, great job!π
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord