@justinconnell
Posted
Hi Neel,
Your solution looks great! It displays well on mobile and desktop devices and you implemented the active states - good going!
I like the fact that you spent some time on documenting your process keep doing this, it separates you from the rest and shows that you give thought to what you are doing and have a workflow and process for delivering code.
Looking at your HTML, it's well formatted - I would suggest you try replacing some div
elements with semantic elements such as <section>, <article>, <figure>
etc this will improve accessibility and search optomisation.
An area that can be improved on which stood out on the HTML, is naming CSS classes - names such as 'para', 'heading' and 'text' are very generic - there are 100's of them all over a site - what you could do to improve code readability is use names that describe the thing they are naming 'para' does not describe 'date published' but 'published-date' does - see where I'm going with this?
It's still early days, you're doing great so far!
I hope you find my feedback helpful,
All the best
Justin
Marked as helpful