Blog-Preview-Card

Community feedback

• 

  P

  Justin Connell•720

  @justinconnellPosted 9 months ago

  Hi Neel,

  Your solution looks great! It displays well on mobile and desktop devices and you implemented the active states - good going!

  I like the fact that you spent some time on documenting your process keep doing this, it separates you from the rest and shows that you give thought to what you are doing and have a workflow and process for delivering code.

  Looking at your HTML, it's well formatted - I would suggest you try replacing some div elements with semantic elements such as <section>, <article>, <figure> etc this will improve accessibility and search optomisation.

  An area that can be improved on which stood out on the HTML, is naming CSS classes - names such as 'para', 'heading' and 'text' are very generic - there are 100's of them all over a site - what you could do to improve code readability is use names that describe the thing they are naming 'para' does not describe 'date published' but 'published-date' does - see where I'm going with this?

  It's still early days, you're doing great so far!

  I hope you find my feedback helpful,

  All the best

  Justin

  Marked as helpful

  0
• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 9 months ago

  Hello @Neel-07!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

  📌 Second: Use <h1> for the main title instead of <h2>.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  0