Adann Jacinto• 790
@DanCodeCraft
Posted
Hey @ElviCanelaH, good job overall.
I can point out a few things you could consider working on:
Design:
- Take care of the hierarchy of the elements (font color, weight, and size matter when you want to direct the user through the element being displayed.
- The learning button should not have a border, and the letter is too thick for such a small element. Imagine this being a side element, not a whole page.
- The shadow on the card when hovering it, is missing.
- You could use the transition effect to make the experience a bit more smooth.
- The project does not fit a cellphone screen.
- Minor, but important: you're missing spaces in your footer.
Code:
- Use a CSS reset when you start a project, so your page is a good experience across different browsers.
- You do not need to, and should not set a height and width on HTML and body. Save that for specific elements, if ever needed to.
- Learn about different units for CSS. The font, for example, should be set in rem, never in pixels.
- Your CSS file is repeating itself twice within the same file.
Keep up the good work!
0
