Design comparison
SolutionDesign
Community feedback
- @R3ygoskiPosted 7 months ago
Salut Florian, congratulations on completing this challenge, it was very well done and closely resembles the proposed design. Congratulations!
I'd like to give you a tip about your HTML. It's well-structured, but lacks semantic meaning, and it's important to make HTML semantic not only for SEO purposes but also for accessibility reasons. Here are some snippets:
<div class="card">
: Instead of using adiv
, you could use a<main>
, as this is where the main content of the page is located.<div class="card_bckg-img">
: Instead of using adiv
, you could use a<figure>
, as thisdiv
is only containing an image.<div class="card_content">
: Instead of using adiv
, you could use an<article>
here, as this content is self-explanatory and independent.
Once again, congratulations! Keep practicing and improving. If you have any questions, feel free to ask below.
Marked as helpful1 - @FloPereira75Posted 7 months ago
Thanks for your feedback! I still have some difficulties with HTML semantics.
It's well noted and I will use it!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord