Blog-Preview-Card

Community feedback

• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezRPosted 12 months ago

  Hello there 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  CSS and Styling:

  • Instead of fixed widths, employ max-width and min-width for flexible and responsive design. For example remove the w-[327px] md:w-[384px] classes and just put a max-w-[384px]. In the case that you want a gap in mobile screen use a w-[95vw] for example.
  • Let the content decide the height of the elements. Use padding and margins strategically for this purpose.

  Accessibility and Semantic HTML:

  • The icons/illustration images are decorative, so their alt text must be empty: alt="".
  • Profile image could benefit from a more descriptive alt text, like alt="Headshot of Greg Hooper".

  I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Pierre•500

  @pBaptistePosted 12 months ago

  Hi Andrés, I've implemented all of the suggestions that you listed, thanks for the help! Best, Pierre @AGutierrezR

  1