BlogPreviewCard challenge.

Community feedback

• 

  Caeser•60

  @ghost237-sysPosted 10 months ago

  Thank you so much for your feedback. I'm a beginner front-end developer and really appreciate your feedback. I have learnt so much already by just reading your response and i look forward to fixing them and doing better in future. Thanks.

  0
• 

  Joyal James•265

  @silkcoderPosted 10 months ago

  Hello there,

  Congrats for completing your task, It looks good, however I have a few suggestions that can make your layout better

  First thing you have to keep in mind is that your layout get viewed in different sized devices. so is not a wise decision to set width for body tag. so you can remove width property from body tag

  body {
     //remove this
      width: 1440px
  }
  

  Next, you can remove margin property you give to container div (we have a better method to center the container :) )

  .container {
     //remove following line
     margin: 200px 250px 150px 580px;
  }
  

  Now the container get aliged to top left, that is not good :) we have to place the container centered in all sized devices. so apply the following propertiese to the body tag in addition to the existing styles

  body {
      //your styles here
      display: flex;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
  }
  

  Now the container get aligned to centered horzontally and vertically. Good job

  you can read more about flex box propertise at https://www.geeksforgeeks.org/introduction-to-css-flexbox/

  Now if you notice, you may see a scroll bar in the window, its because there is a margin property get added to body tag by default. so a recommended method to fix this is to use a reset css file

  [this is a sample reset css file] (https://meyerweb.com/eric/tools/css/reset/)

  you can download and load this css before loading your styles.css, this file reset all default styles get added to the HTML document

  As a quick fix (without using a reset file) you can add 'margin:0px' to your body tag to remove the scroll bar

  body {
     //all your styles in body tag goes here
     margin:0px;
  }
  

  Now your layout look better.

  I noticed that on your repo, all files (images, css) are scattered, Its good to keep them on separate folders, so that all your images will stay on images folder and your styles to a styles folder

  Good luck with y our future tasks

  Good day

  0