Blog-preview-card

Community feedback

• 

  Hassan Moataz•1,860

  @hassanmoaaPosted 10 months ago

  Hello @Mohamed806H

  Great Job solving the challenge mate *congrats * 🎉

  i see a minor problem that could mess your project if it's bigger and there are more content in it.

  body {
    font-size: 16px;
  }
  

  For the font-size it's is better to use rems and ems but px for this project is no big deal.

  • i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:

  • Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.

  Which properties are affected?

  All of these properties must never ever be declared in pixels:

  • font-size
  • line-height
  • letter-spacing

  If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!

  • You should use ems, and rems for font-sizes would be better

  This article may help:

  https://fedmentor.dev/posts/font-size-px/

  Other than that you're good, keep up the good work!

  Marked as helpful

  1

  ---

  

  Mohamed806H•440

  @Mohamed806HPosted 10 months ago

  Hello @hassanmoaa Thank you 🫡

  0