Mohammed Abbasโข 390
@Mohammedabbas7
Posted
Hello
Congrats on completing this challenge๐๐๐๐.
Nice solution and also like what you did with the attribution.
I noticed a few things in your solution you need to adjust:
- First instead of adding
height: 100vh
to the body element because this causes some overflow issue so addmin-height: 100vh
to make the responsive. - Second instead of adding
height: 60%
to the .content element just add gap propertygap: 1rem
. - you did add a height property to .container element that is not good practice, so don't add specific height to elements unless it's so important to add it.
I hope my advice is useful.
Happy Coding :)
0
Abu Salmanโข 190
@AbuSalman143
Posted
@Mohammedabbas7 Thank you so much for the valuable advice given. In the future, I will make sure to apply your advice to further projects.
0