blog-preview-card

Community feedback

• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezRPosted 11 months ago

  Hello there 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  General Structure and HTML:

  • Wrap the primary content within the <main> tag instead of using it as a standalone component like a <div>.
  • All the content should be contained within landmarks. Every page minimally needs a <main> element.

  CSS and Styling:

  • Implement CSS custom properties to define and utilize project colors more easily.
  • Avoid using px for font-size, you could read this article to learn why. Letter spacing and line height must not be in px, use rem for all the font-related properties.
  • Instead of fixed widths, employ max-width and min-width for flexible and responsive design.
  • Let the content decide the height of the elements. Use padding and margins strategically for this purpose.
  • The body should not have its height limited. Instead of using height: 90vh, use min-height: 100vh.
  • Avoid the use of percentages in padding and margin properties

  Accessibility and Semantic HTML:

  • The icons/illustration images are decorative, so their alt text must be empty: alt="".
  • Profile image could benefit from a more descriptive alt text, like alt="Headshot of Greg Hooper".
  • Maintain semantic HTML structure by using appropriate elements for their intended purposes.

  I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

  Happy coding!

  Marked as helpful

  0

  ---

  

  T-r-i-c-k-y-002•120

  @T-r-i-c-k-y-002Posted 10 months ago

  Thanks @AGutierrezR . From the next challenge, I will implement the points that you have told. :)

  0
• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 11 months ago

  Hello @T-r-i-c-k-y-002!

  You did a very good job there!

  I have just a couple of very simple suggestions for improvement:

  • Since the title is a clickable element, it's nice to add cursor: pointer to it in addition to the color shift hover effect.

  • Darken the description of the card a little bit. Currently it's too light and it doesn't have enough contrast between the background and the text. This helps to improve accessibility.

  Other than those details, you did a great job!

  1

  ---

  

  T-r-i-c-k-y-002•120

  @T-r-i-c-k-y-002Posted 10 months ago

  @danielmrz-dev Thanks for your valuable comment and I'll use your suggestion in upcoming challenges(for writing the code more effectively).

  0