Bloging preview card

Community feedback

• 

  Bryan Li•3,530

  @Zy8712Posted 7 months ago

  Appearance wise, your site and code look pretty solid.

  The main things I'd change are:

  • your <div> with class cotainer to a <main> tag for accessibility reasons, also you don't refer to the this class anywhere in your css so that div is sort of redundant
  • instead of using a <h2> tag you should use an <h1> tag as headers are meant to be used in order from h1 to h6 without any skips. The headings come with default font sizes that can be changed using the font-size attribute in css
  • the one thing your site is missing is the hover effect for the text and card, you can added the hover effect using the :hover selector in css

  Hope you find this feedback useful. If you have any questions feel free to ask 👍

  Marked as helpful

  0

  ---

  

  P

  yoe7501•410

  @yoe7501Posted 7 months ago

  @Zy8712 Are there any issue with me using a lot of flex boxes? I feel like used them any time i needed to center anything including the nested <div> and the :hover affect I didn't see on the design. Thank you though :).

  0

  

  Bryan Li•3,530

  @Zy8712Posted 7 months ago

  @yoe7501 Technically there are no issues with you using a bunch of flexboxes to center items. Though, there may be some more efficient ways of organizing the items in your site. Sometimes you can use gridbox, margins or paddings/border-box in certain cases to layout the items in a component, instead of using flexbox all the time.

  These are generally things, you'll learn as you practice more and experiment more with padding, margins, border box, gridbox, etc.

  But you've pretty much got a bunch of the fundamentals down already which is already great!

  0
• 

  Sahil Kumar Ray•50

  @sahiwlPosted 7 months ago

  will try to improve the alignment better next time

  0