Design comparison
SolutionDesign
Solution retrospective
Hi guys, I did this challenge with rems. Feedback is welcome. 😊
Community feedback
- @redizorkPosted 5 months ago
trebala si na main staviti 2rem border-radius a na img 1rem...za oko ljepse ;)
Marked as helpful0 - @BlackpachamamePosted 10 months ago
Hey your solution is amazing! 🤩
📌 Some accessibility and semantics recommendations for your HTML
- For your
<p>Published 21 Dec 2023</p>
you can use thetime
tag:<p>Published <time datetime="2023-12-21">21 Dec 2023</time></p>
. More info - I can only mention an accessibility issue, you can add a short description to your image with the
alt
attribute. In case it is just a decorative image, such as an icon or logo, you can leave it empty:alt=""
. More info
📌 Other suggestions
- You can use the
gap
property in thebody
to separate yourmain
from yourfooter
- You can apply
display: block
to the image to remove the white space generated underneath. Although visually in this case it is irrelevant, it helps you better calculate the space with other elements - It doesn't seem necessary for you to put your
img
inside asection
- Wouldn't it be better to give your entire card the same
padding
and remove themargin-left
? - The
flex-basis
property doesn't seem to have any use here
Marked as helpful0 - For your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord