Boris• 2,870
@mkboris
Posted
Hi Adebukol nice work, some few things you should look at moving forward
- It's not good practice to wrap every element in
divs because divs aren't semantic, the paragraphs, and heading needs to bepandh1. Also the learning text in the yellow box is not abuttonits just apelement. Learn more about HTML semantic elements here - All content should be wrapped within landmarks. Wrap a
maintag around card. and afooterfor the attribution - Use relative units like
remsoremmore as px can cause lots of issues with responsiveness - Media queries, font-size should be defined in
remnot px - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
- It's best practice linking Google fonts directly in the HTML
headsection rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
Hope thus helps
Marked as helpful
0
@Adebukol
Posted
@mkboris thank you so much
1
@Adebukol
Posted
@mkboris I was Also trying to pass the accessibility test, do you know how I can go about that or just ignore it?
0
