Design comparison
SolutionDesign
Community feedback
- @mkborisPosted 3 months ago
Nice work Ashwini202213, here are a few things to review
- All content should be wrapped within landmarks. Wrap a
main
tag around the .main-container and afooter
for the attribution. - You can use flexbox to properly center the card, add this on your
body
min-height: 100vh; display: flex; align-items: center; flex-direction: column; justify-content: center;
- Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
- Font-size should be written in
rem
not px
Marked as helpful2 - All content should be wrapped within landmarks. Wrap a
- @salva-itPosted 3 months ago
Congratulations on completing the project
- For better structure, you can use <header>, <main>, and <footer> tags.
- To reduce loading time, it is better to move internal styles (
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord