@tinuola
Posted
Hello LLL0908. Congrats on completing your second project!
Good job using flexbox to work out the positioning -- centering the component, and the user/byline row.
One area of improvement would be to use more semantic HTML elements. Instead of the 'div class p1/p2/p3/p4", use descriptive tags such as p, h1, h2 etc. Divs are generic--they have no meaning and are best used for grouping elements, which you've done well in some areas of the code.
Also, the class names "p1/p2/p3, etc" are not particularly intuitive or meaningful. Instead use descriptive names for the classes, such as "card-heading" / "card-subtitle" / "card-description", etc. Meaningful and descriptive naming makes code more readable.
I recommend refactoring the code and then practicing these tips in future challenges.
Good luck!
Marked as helpful
@LLL0908
Posted
Thank you for your feedback! I really didn't express my code clearly. I have refactored the code and will pay attention to use more semantic HTML elements in the following challenges.
