Blog preview in Html and CSS

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 7 months ago

  HTML:

  • Remove the text that is commented out.

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change .main into a <main>.

  • You do not need any <span> tags, nor the <div> around the published date.

  • Use the <time> element for the date: <p>Published <time datetime="2023-12-21">21 Dec 2023</time></p>.

  • As this is a blog card, the heading needs a link inside.

  • The profile image has meaning, so it must have a short and descriptive alt text: "Headshot of Gary Hooper", for example.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • Remove text-decoration: none; and list-style: none;, they are not needed, and should not be placed on the universal selector (*).

  • I would move the properties on .main to body. Remove width, as block elements are 100% wide by default.

  • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove the width on the card.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • On the images, add display: block and max-width: 100% - the max-width prevents overflowing of the container.

  • Media queries must be in rem or em, not px. It is good practice to do the mobile styling as the default.

  Marked as helpful

  0