Design comparison
Solution retrospective
Hey frontend mentor community! ๐
Does anyone have any resources on deploying React projects to GitHub?
- It took me a while to figure out how to deploy this, and I'd love to do this in a more organized manner.
Please feel free to add any advice you have!
Thank you!
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @dashaunn!
Your solution looks great!
I have a couple of suggestions for improvement:
- First: In order to make your HTML code more semantic, use
<h1>
for the main title instead of<h2>
. Unlike what most people think, it's not just about the size and weight of the text.
๐ The
<h1>
to<h6>
tags are used to define HTML headings.๐
<h1>
defines the most important heading.๐
<h6>
defines the least important heading.๐ Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.- Second: Still about semantic HTML, use
<main>
to wrap the main content instead of<div>
or<arcitle>
.
๐ The tag
<div>
has no semantic value and the tag<article>
would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful1 - First: In order to make your HTML code more semantic, use
- @PhatJackPosted 10 months ago
I frequently use Vercel and Netlify to launch websites.
You can try it
About the Preview Site, I see that the text "Published ..." is gone
Try to fix that
2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord