Lyna• 260
@lynaIFR
Posted
Congrats on completing this challenge, here are things you can improve:
- never use
px
forfont-size
, instead userem
. - any website is responsive by default, but when we set a value to the width of elements, that responsiveness will be affected, I saw in your code that you gave a value to the width of your elements, if you want for an element to have a proper size, give it a max-width.
- you used a flex display, that's good, use all of its properties to organize the space between your elements like
gap
, don't use padding and margin everywhere, that's bad practice and it will cause problems - in your html try using proper tags other than
div
, for the card content you could use thearticle
tag for exemple Overall you did a great job, keep going 😁
Marked as helpful
1
Fatma Tawfeek• 100
@Fatma-Tawfeek
Posted
@lynaIFR Thanx very much for your feedback, Lyna. I really appreciate it, and I will definitely consider it next time.
0