@takinabradley
Posted
I like the project! Everything seems pretty neat and the code is easy to follow.
Since it seems like the learner has figured out deployment, I only have a couple comments:
-
To do the font-size challenge without media queries, they likely could have used something like
clamp(). It seems like they used a media query anyway. -
There may have been a chance or two to add another component, or at least "BEM blocks" with unique class names here (perhaps a "Tag" component and a "Profile" block?). I like the SCSS, but continuing nested styles like this could become quite long, and you may lose it's readability benefits. An alternative to adding more block names/components might be big obvious comments that draw your attention to where styles for certain parts of the card start, like the card footer.
