Design comparison
Community feedback
- @Islandstone89Posted 4 months ago
HTML:
-
Every webpage needs a
<main>
that wraps all of the content, except for<header>
andfooter>
. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a<main>
. -
Alt text should be written naturally, without using
-
between the words. You should not use words like "image", as screen readers announce images as "image" by default. -
I would wrap the date in a
<time>
element:<p>Published <time datetime="2023-12-21">21 Dec 2023</time></p>
. -
Headings should always be in order, so you never start with a
<h3>
. Change it into a<h2>
. An<h1>
is reserved for the main heading on a page, which would likely not be a card heading.
CSS:
-
Including a CSS Reset at the top is good practice.
-
I like to add
1rem
ofpadding
on thebody
, to ensure the card doesn't touch the edges on small screens. -
On the
body
, changeheight
tomin-height
- this way, the content will not get cut off if it grows beneath the viewport. -
Except for the author image, remove all widths and heights. Except for icons, you rarely want to set fixed dimensions(especially heights), as this easily creates issues with responsiveness.
-
Add a
max-width
of around20rem
on the card, to prevent it from getting too wide on larger screens. -
font-size
must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
It's best practice to set
display: block
andmax-width: 100%
on images. The max-width prevents images from overflowing their container if the intrinsic width of the image is larger than the container width.
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord