Blog Preview card with focus and hover states

Community feedback

• 

  raya•2,850

  @rayaattaPosted 10 months ago

  Hi Madhavan, congratulations completing this challenge 🎉 I have some tips that might probably spark your interest 1.the <footer> tag is a land mark for a page,it acts like a better alternative to a div.this means that text inside the footer should be enclosed inside an html tag for text such as a <p> element 2.I noticed you enclosed an <h1> tag inside an <a> element in this piece of code

         <h1 class="card__heading">HTML & CSS foundations</h1>
       </a>
  

  You have to interchange this for accessibility reasons. The <h1>should enclose the <a>. 3.it is better to include the link to your fonts inside the html file. 4.I liked that you experimented with the :has() selector.But you could have achieved the same effects with just

   .card:hover /*you add other selectors here to target child and descendants elements here*/ 
  {
  /*Effects here*/
  } 
  

  Apart from that your project is awesome

  Marked as helpful

  1

  ---

  

  Madhavan•340

  @madhavan-tsPosted 10 months ago

  @rayaatta Thank you for your comment on my code and the time you put on reviewing the code. This was quite helpful for me. I will correct these mistakes.

  1

  

  raya•2,850

  @rayaattaPosted 10 months ago

  Welcome. I'm always happy to help@madhavan-ts

  0