@TedJenkler
Posted
Hi @emeraldknytt,
Nice project! I noticed a couple of things that could be improved:
Semantic HTML: Instead of using multiple <div> elements, you should consider using semantic HTML. For instance, your card could be wrapped in a <main> tag, and you could purge most of the unnecessary <div>s. Using Flexbox with flex-direction: column inside the card would give you a cleaner design and improve readability, SEO, and accessibility.
Heading Usage: The <h1> tag is meant for page titles and should be used only once per page. While you’ve correctly used it just once here, in smaller projects or components like this, you can skip using <h1> and go with an <h2> instead. If you had multiple cards on the same page, using several <h1> tags would violate the one <h1> rule.
Use of <time>: When displaying a time element, consider using the <time> tag to further improve accessibility and readability.
Keep up the great work!
Best, Teodor
Marked as helpful