Marcos Travagliniβ’ 4,920
@Blackpachamame
Posted
Good job!
Here are some comments that may help you:
- Use semantic tags such as
main
,footer
,figure
, etc, this helps the accessibility and SEO of the site - The
<div class="container">
should be<main class="container">
- The
<div class="attribution">
should be<footer class="attribution">
. Also, you should put it outside themain
and remove theposition absolute
properties, since they will not be necessary. - Instead of using
justify-content: center
andalign-items: center
, you can replace them withplace-content: center
- You do not need to define the
grid-template-columns
andgrid-template-row
in thebody
- Apply
display: block
to the image to remove that annoying white space
Marked as helpful
1
Tenzin Choedaβ’ 210
@tenze21
Posted
wow, thanks a lot @Blackpachamame for your suggestions, they are really helpful.
1