Blog preview card with CSS grid

Community feedback

• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  Good job!

  Here are some comments that may help you:

  • Use semantic tags such as main, footer, figure, etc, this helps the accessibility and SEO of the site
  • The <div class="container"> should be <main class="container">
  • The <div class="attribution"> should be <footer class="attribution">. Also, you should put it outside the main and remove the position absolute properties, since they will not be necessary.
  • Instead of using justify-content: center and align-items: center, you can replace them with place-content: center
  • You do not need to define the grid-template-columns and grid-template-row in the body
  • Apply display: block to the image to remove that annoying white space

  Marked as helpful

  1

  ---

  

  Tenzin Choeda•210

  @tenze21Posted 10 months ago

  wow, thanks a lot @Blackpachamame for your suggestions, they are really helpful.

  1