Blog preview card

Community feedback

• 

  AmyH-goose•120

  @AmyH-goosePosted 3 months ago

  I believe you did remarkably. As a beginner too, I've learned a few things from looking at your code (thanks!). I think to make sure that people who choose to have different font sizes on their browser have a better experience, use rem or em instead of hard px so that it adjusts along with their setting choices.

  Marked as helpful

  1
• 

  P

  Øystein Håberg•12,740

  @Islandstone89Posted 3 months ago

  HTML:

  • I would wrap the date in a <time> tag: <p class="date">Published <time datetime="2023-12-21">21 Dec 2023</time></p>.

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  • As this is a blog card, the heading should have a link inside.

  • A better alt text for the profile image would be something like "Headshot of Greg Hooper".

  • Wrap the footer text in a <p>.

  CSS:

  • Make a habit of always including a proper CSS Reset at the top of the stylesheet.

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • Remember to specify a fallback font: font-family: 'Figtree', system-ui, sans-serif;

  • Add a gap of around 20px on the body, so the <footer> doesn't squeeze up against the card.

  • Remove the styles on .main_container, they are not needed.

  • Remove height: fit-content on the card, it is not needed.

  • Remove the width in px on the card. We rarely want to give a component a fixed size, as we need it to grow and shrink according to the screen size.

  • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • I don't think this challenge needs any media queries. When you do need them, they should be in rem or em, not px. Also, it is common practice to do mobile styles first and use media queries for larger screens.

  Marked as helpful

  0