@noelhoppe
Posted
Hi, here are some suggestions:
- As you know, it's good practice to separate structure (HTML) from design (CSS). That's why you can "link" your font-family with @import statement in css:
@import url('https://fonts.googleapis.com/css2?family=Figtree:wght@500;600;800&display=swap');
-
Remove line-height: 20px from the <footer>, it's overridden all the time. As you have don instead, it's good practice to use rem for line-height all the time.
-
Maybe you can define the colors in the :root element with css variables and than acces later on. That allows you to make comfortable changes.
- <h3>Learning</h3> has to be a <p>-tag,
<span>Published 06 Jan 2024</span> has to be also a <p>-tag
-
Remove the <a> tag in line 34 and the <div> tag in line 35
-
In general, you use some unnecessary <div> containers, maybe it's a good practice to try to remove some <div> in your body{}. Tipp: I have used only one <div> in body.
-
Add in your css to body { min.-height: 100vh; display: flex; flex-direction:column;
But all in all: Good job, enjoy coding! justify-content: center; } to center your card.
Marked as helpful
@rame0033
Posted
@noelhoppe thank you for this comprehensive marking. I appreciate every details. :)