Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

blog preview card

rofeehart 100

@rofeehart

Desktop design screenshot for the Blog preview card coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P
Steven Stroud 4,140

@Stroudy

Posted

Firstly great solution you should be proud of! A few things I noticed,

  • Missing a alt="" on your <img>, Having better alt="" descriptions for accessibility is a must check this out Write helpful Alt Text to describe images,
  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
  • Missing a <meta> description tag for SEO purposes,
  • It is best practice to have a <main> tag inside your body highlighting the main section.
  • Image avatar bottom left failed to load, I think putting a . in front of the / like this <img src="./assets/images/image-avatar.webp"> will solve the issue, I believe this is something to do with how GitHub finds files, The main difference between an absolute file path and a relative file path is that an absolute path specifies the full location of a file or directory, while a relative path specifies the location of a file or directory in relation to the current working directory.
  • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
  • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
  • Another great resource for px to rem converter.
  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
  • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset, Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.

I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord