Design comparison
Solution retrospective
Hello, Frontend Mentor coding community. This is my solution for the Blog preview card.
A quick challenge that I finished in one day.
Every section I cover on reac.tjs, I use the opportunity to build a simple small component. Therefore, I used functional components to build the projects
Added Features: AOS Library Please review and advice
Community feedback
- @DylandeBruijnPosted 5 months ago
@nonoza
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution 🎉
- Clear descriptive CSS classes
- Use of React.js
- Clear component structure
Things you could improve ✍️
- Try making your CSS values more reusable by using CSS custom properties.
- Use CSS relative units like
rem
andem
. - Make the card more responsive by making it fluid when the viewport gets too small.
- Replace the
<small>
element by an element that's more semantically meaningful. - Wrap your main content in a
<main>
. - Replace the
<div>
for the.blog-preview-container
by an<article>
. - Experiment more with Flexbox, try using the
gap
property. - Be careful with setting a fixed
width
andheight
on elements like your.blog-preview-container
. At the moment you will run into overflow issues when the content of your card gets bigger than thewidth
andheight
. I suggest keeping theheight
fluid. The defaultheight
ofauto
which is set onblock
elements would suffice.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful0@nonozaPosted 5 months ago@DylandeBruijn Thank you so much for your comment. I will do some changes on my project and ask you when I have questions.
1@nonozaPosted 5 months ago@DylandeBruijn One more question, for this comment "Replace the <small> element by an element that's more semantically meaningful." : Is it fine if I use a p tag for things like category?
1@DylandeBruijnPosted 5 months ago@nonoza
Hiya, yes it's completely fine to use
<p>
for the category and description!Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord